Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251551: Use .md filename extension for README #47

Closed
wants to merge 1 commit into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Jun 20, 2022

backports https://bugs.openjdk.org/browse/JDK-8251551 as it's a low risk change


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u pull/47/head:pull/47
$ git checkout pull/47

Update a local copy of the PR:
$ git checkout pull/47
$ git pull https://git.openjdk.org/jdk11u pull/47/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 47

View PR using the GUI difftool:
$ git pr show -t 47

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/47.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2022

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 20, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 20, 2022

Webrevs

@gdams gdams changed the title 8251551: Use .md filename extension for README Backport 6ed221cb9ad2e81d92dda0ef32095dda5d52cb85 Jun 20, 2022
@openjdk openjdk bot changed the title Backport 6ed221cb9ad2e81d92dda0ef32095dda5d52cb85 8251551: Use .md filename extension for README Jun 20, 2022
@openjdk
Copy link

openjdk bot commented Jun 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jun 20, 2022
@phohensee
Copy link
Member

Unless this is a critical fix, it needs to be against jdk11u-dev rather than jdk11u.

@gdams
Copy link
Member Author

gdams commented Jun 20, 2022

Unless this is a critical fix, it needs to be against jdk11u-dev rather than jdk11u.

@phohensee apologies - I've moved the PR to openjdk/jdk11u-dev#1161

@gdams gdams closed this Jun 20, 2022
@gdams gdams deleted the readme branch June 20, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
2 participants