Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8028265: Add legacy tz tests to OpenJDK #55

Closed
wants to merge 1 commit into from

Conversation

alvdavi
Copy link
Contributor

@alvdavi alvdavi commented Sep 15, 2022

Clean backport of JDK-8028265, bringing timezone tests before updating timezone data to 2022c. All tests in test/jdk/java/util/TimeZone are passing


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u pull/55/head:pull/55
$ git checkout pull/55

Update a local copy of the PR:
$ git checkout pull/55
$ git pull https://git.openjdk.org/jdk11u pull/55/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 55

View PR using the GUI difftool:
$ git pr show -t 55

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/55.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2022

👋 Welcome back alvdavi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 92deab546549ca549408a983fe361d9536d2cd37 8028265: Add legacy tz tests to OpenJDK Sep 15, 2022
@openjdk
Copy link

openjdk bot commented Sep 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 15, 2022

@alvdavi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8028265: Add legacy tz tests to OpenJDK

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e9ba915: 8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Sep 16, 2022

Pre-submit failure: CompensatedSums, known to be failing eventually, unrelated.

@GoeLin
Copy link
Member

GoeLin commented Sep 16, 2022

@alvdavi please check the Pre-submit tests before labeling fix-request. I won't approve a change with failing tests.

@gnu-andrew
Copy link
Member

I see jdk11u-critical-yes now

@gnu-andrew
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 16, 2022

@gnu-andrew The change author (@alvdavi) must issue an integrate command before the integration can be sponsored.

@GoeLin
Copy link
Member

GoeLin commented Sep 19, 2022

@alvdavi please integrate this change. Thanks.

@alvdavi
Copy link
Contributor Author

alvdavi commented Sep 20, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 20, 2022
@openjdk
Copy link

openjdk bot commented Sep 20, 2022

@alvdavi
Your change (at version 6c487d2) is now ready to be sponsored by a Committer.

@gnu-andrew
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 20, 2022

Going to push as commit cd29d6e.
Since your change was applied there has been 1 commit pushed to the master branch:

  • e9ba915: 8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 20, 2022
@openjdk openjdk bot closed this Sep 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 20, 2022
@openjdk
Copy link

openjdk bot commented Sep 20, 2022

@gnu-andrew @alvdavi Pushed as commit cd29d6e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants