-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled #56
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See below. Otherwise, LGTM. Thanks for backporting.
history = String.format( | ||
rb.getString("history.with.ts"), | ||
rb.getString("history.with.ts"), // GLGLGL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to remove the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed. Thanks for finding this!
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate Thanks for reviewing! |
Going to push as commit e9ba915. |
I backport this change from 17u because I had to do adaptions for 17 that
are needed here, too. I needed further fixes, though:
src/java.base/share/classes/sun/security/pkcs/SignerInfo.java
Slight difference in context, change applies to code clean.
I had to change a record to a class to make the change compile
with Java 11.
src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java
Chunks don't apply because in 11 method JAR_DISABLED_CHECK
lacks the prefix JAR_.
checkWeakKey() and checkWeakAlg() are not implemented in 11. Hunk omitted.
test/jdk/sun/security/tools/jarsigner/TimestampCheck.java
Resolved adding bugID to @bug.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u pull/56/head:pull/56
$ git checkout pull/56
Update a local copy of the PR:
$ git checkout pull/56
$ git pull https://git.openjdk.org/jdk11u pull/56/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 56
View PR using the GUI difftool:
$ git pr show -t 56
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/56.diff