8309476: [11u] tools/jmod/hashes/HashesOrderTest.java fails intermittently

[RealCLanger]

The test 'tools/jmod/hashes/HashesOrderTest.java', introduced by JDK-8240903, was backported to 11.0.17 via JDK-8287791. However, JDK11 doesn't support specifying "--date". This appears to be needed in order to make the test reliable. The hashes of two jmod files may differ if the timestamp differs.

The "--date" option was implemented with JDK-8276766 for JDK 19 and has only been backported to JDK 17. It is a feature that comes with a CSR and might not be worthwile doing for the JDK11 updates release. For now, the test should be marked as @Intermittent until JDK-8276766 is brought to JDK11 updates.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309476: [11u] tools/jmod/hashes/HashesOrderTest.java fails intermittently (Bug - "4")

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u.git pull/72/head:pull/72
$ git checkout pull/72

Update a local copy of the PR:
$ git checkout pull/72
$ git pull https://git.openjdk.org/jdk11u.git pull/72/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 72

View PR using the GUI difftool:
$ git pr show -t 72

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/72.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (1ac993b2)

[TheRealMDoerr]

LGTM.

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8309476: [11u] tools/jmod/hashes/HashesOrderTest.java fails intermittently

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealCLanger]

JBS approval received.

/integrate

[openjdk]

Going to push as commit 0770b1f.
Since your change was applied there has been 1 commit pushed to the master branch:

• 1660788: 8304291: [AIX] Broken build after JDK-8301998

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit 0770b1f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.