8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates

[RealCLanger]

Hi all,

This pull request contains a backport of JDK-8303465, commit ac41c030 from the openjdk/jdk repository.

This is an improvement for the handling of certificates from the MacOSX keychain which regressed since the April 2022 CPU update (11.0.15) and does not show all appropriate certificates that it should do. The fix was just recently submitted in head and came too late for the regular dev cycle for 11.0.20. However, I would ask to include it now in rampdown, since we have an open customer issue that it would solve. Since our customer is consuming the JDK via Eclipse/Adoptium, it would also not suffice to cherry-pick it into the SapMachine build only, so that's why my request is to take it into 11.0.20.

The backport applied nearly clean, I only had to adapt some Java code due to lacking instanceof features in 11.

It involves a CSR but the original CSR has been approved for all relevant backport releases.

Thanks
Christoph

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8308690 to be approved

Issues

• JDK-8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates (Bug - P3)
• JDK-8308690: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates (CSR)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u.git pull/73/head:pull/73
$ git checkout pull/73

Update a local copy of the PR:
$ git checkout pull/73
$ git pull https://git.openjdk.org/jdk11u.git pull/73/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 73

View PR using the GUI difftool:
$ git pr show -t 73

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/73.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 1660788: 8304291: [AIX] Broken build after JDK-8301998

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (8ad9826d)
• 00: Full (a2c7185f)

[MBaesken]

LGTM

[RealCLanger]

JBS approval received

/integrate

[openjdk]

Going to push as commit d286dde.
Since your change was applied there have been 2 commits pushed to the master branch:

• 0770b1f: 8309476: [11u] tools/jmod/hashes/HashesOrderTest.java fails intermittently
• 1660788: 8304291: [AIX] Broken build after JDK-8301998

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit d286dde.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.