-
Notifications
You must be signed in to change notification settings - Fork 201
8304291: [AIX] Broken build after JDK-8301998 #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8304291: [AIX] Broken build after JDK-8301998 #74
Conversation
|
👋 Welcome back afarley! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@adamfarley This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
@adamfarley |
|
Hi Adam, I suggest to close this PR as changes must be against the "jdk<n>u-dev" repository. Also, I'm not sure of your intended action here but, as a reminder, integration for an updates project can only happen after the label jdk<n>u-fix-yes is added by a release Maintainer to the JBS ticket —even a Reviewer's approval is not enough. Martin.- |
Nope, that's not quite true. As this change should go in for 11.0.20 rampdown, here is the correct place. Please see also Goetz' JBS comment.
Exactly. Please note this for future backports, @adamfarley. 😉 I'm sponsoring this now (after I approved it in JBS). Cheers Christoph /sponsor |
|
Going to push as commit 1660788. |
|
@RealCLanger @adamfarley Pushed as commit 1660788. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit 310aa934 from the openjdk/jdk repository.
The commit being backported was authored by Matthias Baesken on 20 Apr 2023 and was reviewed by Martin Doerr, Tyler Steele and Phil Race.
Thanks!
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u.git pull/74/head:pull/74$ git checkout pull/74Update a local copy of the PR:
$ git checkout pull/74$ git pull https://git.openjdk.org/jdk11u.git pull/74/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 74View PR using the GUI difftool:
$ git pr show -t 74Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/74.diff
Webrev
Link to Webrev Comment