Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 924720f6fc80 #75

Closed
wants to merge 1 commit into from
Closed

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jun 19, 2023

8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class

Reviewed-by: Yi Yang


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u.git pull/75/head:pull/75
$ git checkout pull/75

Update a local copy of the PR:
$ git checkout pull/75
$ git pull https://git.openjdk.org/jdk11u.git pull/75/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 75

View PR using the GUI difftool:
$ git pr show -t 75

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/75.diff

Webrev

Link to Webrev Comment

…x$WhiteBoxPermission.class

Reviewed-by: Yi Yang
Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2023

👋 Welcome back sendaoYan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mlbridge
Copy link

mlbridge bot commented Jun 19, 2023

Webrevs

@sendaoYan sendaoYan changed the title 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class Backport 924720f6fc80 Jun 19, 2023
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jun 19, 2023
@phohensee
Copy link
Member

This backport is against jdk11u, which is the 11u master and closed for all except critical fixes. Please close this PR and open a new one against jdk11u-dev. Also, the commit id must be the complete id, not just a prefix. Do a "git log" against https://github.com/openjdk/jdk, and find that the 8236045 git commit id is 924720f6fc8060fcd7024e6fca39223413f690ba. The bot won't recognize partial ids.

@sendaoYan
Copy link
Member Author

This backport is against jdk11u, which is the 11u master and closed for all except critical fixes. Please close this PR and open a new one against jdk11u-dev. Also, the commit id must be the complete id, not just a prefix. Do a "git log" against https://github.com/openjdk/jdk, and find that the 8236045 git commit id is 924720f6fc8060fcd7024e6fca39223413f690ba. The bot won't recognize partial ids.

OK, thanks

@sendaoYan sendaoYan closed this Jun 20, 2023
@sendaoYan
Copy link
Member Author

openjdk/jdk11u-dev#1963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants