Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies #85

Closed
wants to merge 1 commit into from
Closed

Conversation

roy-soumadipta
Copy link
Contributor

@roy-soumadipta roy-soumadipta commented Sep 25, 2023

Backporting the fix for https://bugs.openjdk.org/browse/JDK-8315770 merged as part of openjdk/jdk#15631. https://github.com/openjdk/jdk/commit/877731d2a20249ce4724a071ba2da1faa56daca4.patch apply failed due to differences in the file and the changes have been performed selectively.

Below are the test results:

  • after_release: 123.62s user 10.26s system 160% cpu 1:23.59 total
  • after_fastdebug: 197.42s user 15.07s system 195% cpu 1:48.49 total
  • before_release: 123.65s user 9.56s system 159% cpu 1:23.38 total
  • before_fastdebug: 232.70s user 15.29s system 170% cpu 2:25.70 total

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u.git pull/85/head:pull/85
$ git checkout pull/85

Update a local copy of the PR:
$ git checkout pull/85
$ git pull https://git.openjdk.org/jdk11u.git pull/85/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 85

View PR using the GUI difftool:
$ git pr show -t 85

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/85.diff

Webrev

Link to Webrev Comment

Backporting the fix for https://bugs.openjdk.org/browse/JDK-8315770
merged as part of openjdk/jdk#15631. https://github.com/openjdk/jdk/commit/877731d2a20249ce4724a071ba2da1faa56daca4.patch apply failed due to differences in the file and the changes have been performed selectively.

Below are the test results:
* after_release: **123.62s user 10.26s system 160% cpu 1:23.59 total**
* after_fastdebug: **197.42s user 15.07s system 195% cpu 1:48.49 total**
* before_release: **123.65s user 9.56s system 159% cpu 1:23.38 total**
* before_fastdebug: **232.70s user 15.29s system 170% cpu 2:25.70 total**
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 25, 2023

👋 Welcome back roy-soumadipta! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 877731d2a20249ce4724a071ba2da1faa56daca4 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies Sep 25, 2023
@openjdk
Copy link

openjdk bot commented Sep 25, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 25, 2023

@roy-soumadipta This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 25, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 25, 2023

Webrevs

@roy-soumadipta
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 25, 2023
@openjdk
Copy link

openjdk bot commented Sep 25, 2023

@roy-soumadipta
Your change (at version 6b4d79a) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Sep 27, 2023

No, wait, this is not approved for any 11u, so we cannot integrate.
This PR should be against jdk11u-dev, not jdk11u. Please reopen it against jdk11u-dev.

@GoeLin
Copy link
Member

GoeLin commented Sep 27, 2023

/reviewers 1

@openjdk
Copy link

openjdk bot commented Sep 27, 2023

@GoeLin
Warning: By issuing the /reviewers command in this clean backport pull request, the reviewers check has now been enabled.
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 1 (with at least 1 Reviewer).

@openjdk openjdk bot removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels Sep 27, 2023
@roy-soumadipta
Copy link
Contributor Author

Closing this PR due to incorrect repo. Raised backport request in correct repo: openjdk/jdk11u-dev#2150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
3 participants