Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319187: Add three eMudhra emSign roots #88

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Nov 30, 2023

Backport for JDK-8319187, due to the deadline in jdk11u-dev.
openjdk/jdk11u-dev#2290


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319187 needs maintainer approval

Issue

  • JDK-8319187: Add three eMudhra emSign roots (Enhancement - P2 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u.git pull/88/head:pull/88
$ git checkout pull/88

Update a local copy of the PR:
$ git checkout pull/88
$ git pull https://git.openjdk.org/jdk11u.git pull/88/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 88

View PR using the GUI difftool:
$ git pr show -t 88

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/88.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 30, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0bda467f6e29c866c661e88a76a9fe3efc0a0d19 8319187: Add three eMudhra emSign roots Nov 30, 2023
@openjdk
Copy link

openjdk bot commented Nov 30, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 30, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 30, 2023

Webrevs

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Nov 30, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Nov 30, 2023
@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8319187: Add three eMudhra emSign roots

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealLucy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 30, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 30, 2023
@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@luchenlin
Your change (at version 6dd7260) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Nov 30, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 30, 2023

Going to push as commit 09b402a.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 30, 2023
@openjdk openjdk bot closed this Nov 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 30, 2023
@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@GoeLin @luchenlin Pushed as commit 09b402a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants