-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8331750: [11u] JDK-8259530 is not backported correctly to 11u #92
Conversation
👋 Welcome back kyukihiro! A progress list of the required criteria for merging this PR into |
@yukikimmura This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/approval request I would like to fix the issue. |
@yukikimmura |
@yukikimmura Can you please integrate this PR? Thanks. |
/integrate |
@yukikimmura |
/sponsor |
Going to push as commit d3bd5ae. |
@RealCLanger @yukikimmura Pushed as commit d3bd5ae. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This pull request ports a fix from jdk11u-dev.
I have confirmed that the fix passes the following tests:
Could someone please review the fix?
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u.git pull/92/head:pull/92
$ git checkout pull/92
Update a local copy of the PR:
$ git checkout pull/92
$ git pull https://git.openjdk.org/jdk11u.git pull/92/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 92
View PR using the GUI difftool:
$ git pr show -t 92
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/92.diff
Webrev
Link to Webrev Comment