Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331750: [11u] JDK-8259530 is not backported correctly to 11u #92

Closed
wants to merge 1 commit into from

Conversation

yukikimmura
Copy link
Contributor

@yukikimmura yukikimmura commented Jun 1, 2024

This pull request ports a fix from jdk11u-dev.
I have confirmed that the fix passes the following tests:

  • test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java
  • All langtool tests
    Could someone please review the fix?

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331750 needs maintainer approval

Issue

  • JDK-8331750: [11u] JDK-8259530 is not backported correctly to 11u (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u.git pull/92/head:pull/92
$ git checkout pull/92

Update a local copy of the PR:
$ git checkout pull/92
$ git pull https://git.openjdk.org/jdk11u.git pull/92/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 92

View PR using the GUI difftool:
$ git pr show -t 92

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/92.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 1, 2024

👋 Welcome back kyukihiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 1, 2024

@yukikimmura This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8331750: [11u] JDK-8259530 is not backported correctly to 11u

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 1, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 1, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 2, 2024

⚠️ @yukikimmura This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@yukikimmura
Copy link
Contributor Author

/approval request I would like to fix the issue.
The bug is a careless mistake and does not require complex logic to fix, so there is no risk.
I have also thoroughly checked the fix. Testing: All langtool tests.

@openjdk
Copy link

openjdk bot commented Jun 3, 2024

@yukikimmura
8331750: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 3, 2024
@RealCLanger
Copy link
Contributor

@yukikimmura Can you please integrate this PR? Thanks.

@yukikimmura
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 5, 2024
@openjdk
Copy link

openjdk bot commented Jun 5, 2024

@yukikimmura
Your change (at version d70a66d) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 6, 2024

Going to push as commit d3bd5ae.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 6, 2024
@openjdk openjdk bot closed this Jun 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 6, 2024
@openjdk
Copy link

openjdk bot commented Jun 6, 2024

@RealCLanger @yukikimmura Pushed as commit d3bd5ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants