Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods #94

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 3, 2024

I backport this from 17. I had hoped it would be clean, but I had to adapt the nullptr literals in the .cpp files.

Also, I had to resolve the copyright in all four hotspot files.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8338139 needs maintainer approval
  • Change requires CSR request JDK-8338540 to be approved

Issues

  • JDK-8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods (Bug - P1 - Approved)
  • JDK-8338540: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u.git pull/94/head:pull/94
$ git checkout pull/94

Update a local copy of the PR:
$ git checkout pull/94
$ git pull https://git.openjdk.org/jdk11u.git pull/94/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 94

View PR using the GUI difftool:
$ git pr show -t 94

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/94.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 3, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 3, 2024

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 897f433b33a46d56cc6972b1c6b4405ecaa4dea9 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods Sep 3, 2024
@openjdk
Copy link

openjdk bot commented Sep 3, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 3, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 3, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Sep 3, 2024

GHA failure:
macos: Both have the sprintf build problem seen recently

@openjdk
Copy link

openjdk bot commented Sep 3, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Sep 5, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Sep 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Sep 5, 2024

Going to push as commit 6ee8bac.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 5, 2024
@openjdk openjdk bot closed this Sep 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 5, 2024
@openjdk
Copy link

openjdk bot commented Sep 5, 2024

@GoeLin Pushed as commit 6ee8bac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8338139 branch September 5, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants