Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

Commit a34f699

Browse files
Larry-NYuri Nesterenko
authored and
Yuri Nesterenko
committed
8234541: C1 emits an empty message when it inlines successfully
Use "inline" as the message when successfull Backport-of: 4e64af8
1 parent 186e8b2 commit a34f699

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

src/hotspot/share/c1/c1_GraphBuilder.cpp

+4-9
Original file line numberDiff line numberDiff line change
@@ -3810,7 +3810,7 @@ bool GraphBuilder::try_inline_full(ciMethod* callee, bool holder_known, bool ign
38103810
INLINE_BAILOUT("total inlining greater than DesiredMethodLimit");
38113811
}
38123812
// printing
3813-
print_inlining(callee);
3813+
print_inlining(callee, "inline", /*success*/ true);
38143814
}
38153815

38163816
// NOTE: Bailouts from this point on, which occur at the
@@ -4332,16 +4332,11 @@ static void post_inlining_event(EventCompilerInlining* event,
43324332
void GraphBuilder::print_inlining(ciMethod* callee, const char* msg, bool success) {
43334333
CompileLog* log = compilation()->log();
43344334
if (log != NULL) {
4335+
assert(msg != NULL, "inlining msg should not be null!");
43354336
if (success) {
4336-
if (msg != NULL)
4337-
log->inline_success(msg);
4338-
else
4339-
log->inline_success("receiver is statically known");
4337+
log->inline_success(msg);
43404338
} else {
4341-
if (msg != NULL)
4342-
log->inline_fail(msg);
4343-
else
4344-
log->inline_fail("reason unknown");
4339+
log->inline_fail(msg);
43454340
}
43464341
}
43474342
EventCompilerInlining event;

src/hotspot/share/c1/c1_GraphBuilder.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ class GraphBuilder {
381381
void append_unsafe_get_and_set_obj(ciMethod* callee, bool is_add);
382382
void append_char_access(ciMethod* callee, bool is_store);
383383

384-
void print_inlining(ciMethod* callee, const char* msg = NULL, bool success = true);
384+
void print_inlining(ciMethod* callee, const char* msg, bool success = true);
385385

386386
void profile_call(ciMethod* callee, Value recv, ciKlass* predicted_holder, Values* obj_args, bool inlined);
387387
void profile_return_type(Value ret, ciMethod* callee, ciMethod* m = NULL, int bci = -1);

0 commit comments

Comments
 (0)