8250911: [windows] os::pd_map_memory error detection broken

Ekaterina Vergizova · Ekaterina Vergizova · commit d7a63fc92f85 · 2021-03-15T13:04:08.000Z
Backport-of: aab365f
diff --git a/src/hotspot/os/windows/os_windows.cpp b/src/hotspot/os/windows/os_windows.cpp
@@ -4921,7 +4921,7 @@ char* os::pd_map_memory(int fd, const char* file_name, size_t file_offset,
 
   hFile = CreateFile(file_name, GENERIC_READ, FILE_SHARE_READ, NULL,
                      OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL);
-  if (hFile == NULL) {
+  if (hFile == INVALID_HANDLE_VALUE) {
     log_info(os)("CreateFile() failed: GetLastError->%ld.", GetLastError());
     return NULL;
   }

Original file line number	Diff line number	Diff line change
`@@ -4921,7 +4921,7 @@ char* os::pd_map_memory(int fd, const char* file_name, size_t file_offset,`
`4921`	`4921`
`4922`	`4922`	`hFile = CreateFile(file_name, GENERIC_READ, FILE_SHARE_READ, NULL,`
`4923`	`4923`	`OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL);`
`4924`		`- if (hFile == NULL) {`
	`4924`	`+ if (hFile == INVALID_HANDLE_VALUE) {`
`4925`	`4925`	`log_info(os)("CreateFile() failed: GetLastError->%ld.", GetLastError());`
`4926`	`4926`	`return NULL;`
`4927`	`4927`	`}`