8272806: [macOS] "Apple AWT Internal Exception" when input method is changed

Yuri Nesterenko · Yuri Nesterenko · commit e5ddcb1cdd4d · 2022-07-29T10:05:29.000Z
Backport-of: f681d6544ac2506cb72e45c1f9ed8dfbbde099f2
diff --git a/src/java.desktop/macosx/native/libawt_lwawt/awt/CInputMethod.m b/src/java.desktop/macosx/native/libawt_lwawt/awt/CInputMethod.m
@@ -115,9 +115,7 @@ + (void) _nativeNotifyPeerWithView:(AWTView *)view inputMethod:(jobject) inputMe
     AWT_ASSERT_APPKIT_THREAD;
 
     if (!view) return;
-    if (!inputMethod) return;
-
-    [view setInputMethod:inputMethod]; // inputMethod is a GlobalRef
+    [view setInputMethod:inputMethod]; // inputMethod is a GlobalRef or null to disable.
 }
 
 + (void) _nativeEndComposition:(AWTView *)view {
diff --git a/src/java.desktop/macosx/native/libawt_lwawt/awt/LWCToolkit.m b/src/java.desktop/macosx/native/libawt_lwawt/awt/LWCToolkit.m
@@ -259,6 +259,7 @@ BOOL isSWTInWebStart(JNIEnv* env) {
 
 static void AWT_NSUncaughtExceptionHandler(NSException *exception) {
     NSLog(@"Apple AWT Internal Exception: %@", [exception description]);
+    NSLog(@"trace: %@", [exception callStackSymbols]);
 }
 
 @interface AWTStarter : NSObject

Original file line number	Diff line number	Diff line change
`@@ -115,9 +115,7 @@ + (void) _nativeNotifyPeerWithView:(AWTView *)view inputMethod:(jobject) inputMe`
`115`	`115`	`AWT_ASSERT_APPKIT_THREAD;`
`116`	`116`
`117`	`117`	`if (!view) return;`
`118`		`- if (!inputMethod) return;`
`119`		`-`
`120`		`- [view setInputMethod:inputMethod]; // inputMethod is a GlobalRef`
	`118`	`+ [view setInputMethod:inputMethod]; // inputMethod is a GlobalRef or null to disable.`
`121`	`119`	`}`
`122`	`120`
`123`	`121`	`+ (void) _nativeEndComposition:(AWTView *)view {`
Original file line number	Diff line number	Diff line change
`@@ -259,6 +259,7 @@ BOOL isSWTInWebStart(JNIEnv* env) {`
`259`	`259`
`260`	`260`	`static void AWT_NSUncaughtExceptionHandler(NSException *exception) {`
`261`	`261`	`NSLog(@"Apple AWT Internal Exception: %@", [exception description]);`
	`262`	`+ NSLog(@"trace: %@", [exception callStackSymbols]);`
`262`	`263`	`}`
`263`	`264`
`264`	`265`	`@interface AWTStarter : NSObject`