Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253528: Update .jcheck/conf for jdk13u-dev #1

Closed
wants to merge 1 commit into from
Closed

8253528: Update .jcheck/conf for jdk13u-dev #1

wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Sep 23, 2020

Hi all,

Please review this initial jcheck configuration for use with the Skara tooling.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/1/head:pull/1
$ git checkout pull/1

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 23, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8253528 8253528: Update .jcheck/conf for jdk13u-dev Sep 23, 2020
@openjdk openjdk bot added the rfr label Sep 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2020

@rwestberg The following label will be automatically applied to this pull request: build.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the build label Sep 23, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 23, 2020

Webrevs

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Sep 23, 2020

/reviewer credit yan

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2020

@yan-too Only the author (@rwestberg) is allowed to issue the reviewer command.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2020

@rwestberg This change now passes all automated pre-integration checks

After integration, the commit message will be:

8253528: Update .jcheck/conf for jdk13u-dev

Reviewed-by: yan, ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 1810a6d8a42e760b241d837e71ab2e5b071da94a.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 23, 2020
@yan-too
Copy link
Collaborator

@yan-too yan-too commented Sep 23, 2020

Note that the first line looks
rwestberg wants to merge 1 commit into openjdk:master
while the link is, as expected, https://github.com/openjdk/jdk13u-dev
Not a big deal though, the name of repo is everywhere

edvbld
edvbld approved these changes Sep 23, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Sep 23, 2020

/integrate

@openjdk openjdk bot closed this Sep 23, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2020

@rwestberg Pushed as commit e13ab22.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
3 participants