Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8 on Japanese Windows. #100

Closed
wants to merge 1 commit into from

Conversation

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Jan 29, 2021

I'd like to port the issue to 13u. The patch goes without adjustments, problem is reproduced (and was reproduced first in 13).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8 on Japanese Windows.

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/100/head:pull/100
$ git checkout pull/100

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 29, 2021

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e15e30fef22ddffcaef9449648ae93b407a7b598 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8 on Japanese Windows. Jan 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 29, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 29, 2021

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8 on Japanese Windows.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 49b1754: 6532025: GIF reader throws misleading exception with truncated images
  • a27970f: 8243290: Improve diagnostic messages for class verification and redefinition failures
  • fd622d3: 8256809: Annotation processing causes NPE during flow analysis
  • 5c15783: 8212160: JVMTI agent crashes with "assert(_value != 0LL) failed: resolving NULL _value"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 29, 2021

Webrevs

@yan-too
Copy link
Collaborator Author

@yan-too yan-too commented Feb 1, 2021

/integrate

@openjdk openjdk bot closed this Feb 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2021

@yan-too Since your change was applied there have been 6 commits pushed to the master branch:

  • 3678a7b: 8236124: Minimal VM slowdebug build failed after JDK-8212160
  • 7217f4c: 8235456: Minimal VM is broken after JDK-8212160
  • 49b1754: 6532025: GIF reader throws misleading exception with truncated images
  • a27970f: 8243290: Improve diagnostic messages for class verification and redefinition failures
  • fd622d3: 8256809: Annotation processing causes NPE during flow analysis
  • 5c15783: 8212160: JVMTI agent crashes with "assert(_value != 0LL) failed: resolving NULL _value"

Your commit was automatically rebased without conflicts.

Pushed as commit 7a3ce72.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the yan-too:bp8249215 branch Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant