Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8238710: LingeredApp doesn't log stdout/stderr if exits with non-zero code #102

Closed
wants to merge 1 commit into from

Conversation

@Larry-N
Copy link
Contributor

@Larry-N Larry-N commented Feb 1, 2021

Backport fix for bug JDK-8238710. Tested with tier1 and tier2.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8238710: LingeredApp doesn't log stdout/stderr if exits with non-zero code

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/102/head:pull/102
$ git checkout pull/102

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 1, 2021

👋 Welcome back Larry-N! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport bcb804f07f290e70fe0e2a243f98aec7a3ec0497 8238710: LingeredApp doesn't log stdout/stderr if exits with non-zero code Feb 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2021

@Larry-N This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8238710: LingeredApp doesn't log stdout/stderr if exits with non-zero code

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 186e8b2: 8236772: Fix build for windows 32-bit after 8212160 and 8234331.
  • 01fffd0: 8243389: enhance os::pd_print_cpu_info on linux
  • 7a3ce72: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8 on Japanese Windows.
  • 3678a7b: 8236124: Minimal VM slowdebug build failed after JDK-8212160
  • 7217f4c: 8235456: Minimal VM is broken after JDK-8212160
  • 49b1754: 6532025: GIF reader throws misleading exception with truncated images
  • a27970f: 8243290: Improve diagnostic messages for class verification and redefinition failures
  • fd622d3: 8256809: Annotation processing causes NPE during flow analysis
  • 5c15783: 8212160: JVMTI agent crashes with "assert(_value != 0LL) failed: resolving NULL _value"
  • 80f30ba: 8234687: change javap reporting on unknown attributes
  • ... and 1 more: https://git.openjdk.java.net/jdk13u-dev/compare/9be352b3b6bde40ce8100142b8342247b1136db3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 1, 2021

Webrevs

Loading

@Larry-N
Copy link
Contributor Author

@Larry-N Larry-N commented Feb 3, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Feb 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2021

@Larry-N
Your change (at version b49efd1) is now ready to be sponsored by a Committer.

Loading

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Feb 3, 2021

/sponsor

Loading

@openjdk openjdk bot closed this Feb 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2021

@yan-too @Larry-N Since your change was applied there have been 13 commits pushed to the master branch:

  • 6778089: 8241478: vmTestbase/gc/gctests/Steal/steal001/steal001.java fails with OOME
  • a34f699: 8234541: C1 emits an empty message when it inlines successfully
  • 186e8b2: 8236772: Fix build for windows 32-bit after 8212160 and 8234331.
  • 01fffd0: 8243389: enhance os::pd_print_cpu_info on linux
  • 7a3ce72: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8 on Japanese Windows.
  • 3678a7b: 8236124: Minimal VM slowdebug build failed after JDK-8212160
  • 7217f4c: 8235456: Minimal VM is broken after JDK-8212160
  • 49b1754: 6532025: GIF reader throws misleading exception with truncated images
  • a27970f: 8243290: Improve diagnostic messages for class verification and redefinition failures
  • fd622d3: 8256809: Annotation processing causes NPE during flow analysis
  • ... and 3 more: https://git.openjdk.java.net/jdk13u-dev/compare/9be352b3b6bde40ce8100142b8342247b1136db3...master

Your commit was automatically rebased without conflicts.

Pushed as commit e2fbd26.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@Larry-N Larry-N deleted the backport-bcb804f0 branch May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants