Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8234541: C1 emits an empty message when it inlines successfully #104

Closed
wants to merge 1 commit into from

Conversation

Larry-N
Copy link
Contributor

@Larry-N Larry-N commented Feb 1, 2021

Backport fix for bug JDK-8234541. Tested with tier1 and tier2


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8234541: C1 emits an empty message when it inlines successfully

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/104/head:pull/104
$ git checkout pull/104

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2021

👋 Welcome back Larry-N! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4e64af81a2ea66313d03b720004667bc7975f6e4 8234541: C1 emits an empty message when it inlines successfully Feb 1, 2021
@openjdk
Copy link

openjdk bot commented Feb 1, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 1, 2021

@Larry-N This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8234541: C1 emits an empty message when it inlines successfully

Use "inline" as the message when successfull

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 186e8b2: 8236772: Fix build for windows 32-bit after 8212160 and 8234331.
  • 01fffd0: 8243389: enhance os::pd_print_cpu_info on linux
  • 7a3ce72: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8 on Japanese Windows.
  • 3678a7b: 8236124: Minimal VM slowdebug build failed after JDK-8212160
  • 7217f4c: 8235456: Minimal VM is broken after JDK-8212160
  • 49b1754: 6532025: GIF reader throws misleading exception with truncated images
  • a27970f: 8243290: Improve diagnostic messages for class verification and redefinition failures
  • fd622d3: 8256809: Annotation processing causes NPE during flow analysis
  • 5c15783: 8212160: JVMTI agent crashes with "assert(_value != 0LL) failed: resolving NULL _value"
  • 80f30ba: 8234687: change javap reporting on unknown attributes
  • ... and 1 more: https://git.openjdk.java.net/jdk13u-dev/compare/9be352b3b6bde40ce8100142b8342247b1136db3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2021

Webrevs

@Larry-N
Copy link
Contributor Author

Larry-N commented Feb 3, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 3, 2021
@openjdk
Copy link

openjdk bot commented Feb 3, 2021

@Larry-N
Your change (at version e76929c) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Feb 3, 2021

/sponsor

@openjdk openjdk bot closed this Feb 3, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 3, 2021
@openjdk
Copy link

openjdk bot commented Feb 3, 2021

@yan-too @Larry-N Since your change was applied there have been 11 commits pushed to the master branch:

  • 186e8b2: 8236772: Fix build for windows 32-bit after 8212160 and 8234331.
  • 01fffd0: 8243389: enhance os::pd_print_cpu_info on linux
  • 7a3ce72: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8 on Japanese Windows.
  • 3678a7b: 8236124: Minimal VM slowdebug build failed after JDK-8212160
  • 7217f4c: 8235456: Minimal VM is broken after JDK-8212160
  • 49b1754: 6532025: GIF reader throws misleading exception with truncated images
  • a27970f: 8243290: Improve diagnostic messages for class verification and redefinition failures
  • fd622d3: 8256809: Annotation processing causes NPE during flow analysis
  • 5c15783: 8212160: JVMTI agent crashes with "assert(_value != 0LL) failed: resolving NULL _value"
  • 80f30ba: 8234687: change javap reporting on unknown attributes
  • ... and 1 more: https://git.openjdk.java.net/jdk13u-dev/compare/9be352b3b6bde40ce8100142b8342247b1136db3...master

Your commit was automatically rebased without conflicts.

Pushed as commit a34f699.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Larry-N Larry-N deleted the backport-4e64af81 branch March 18, 2021 22:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants