Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8216324: GetClassMethods is confused by the presence of default methods in super interfaces #109

Closed
wants to merge 1 commit into from

Conversation

@kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Feb 5, 2021

I'd like to backport 8216324 to 13u for parity with 11u.
The patch applies cleanly.
Tested with tier1 and other jvmti tests; new test fails without the patch, passes with it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8216324: GetClassMethods is confused by the presence of default methods in super interfaces

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/109/head:pull/109
$ git checkout pull/109

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 5, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 277ec3d26080275e3c14b7e3f40c15e5cdfa3821 8216324: GetClassMethods is confused by the presence of default methods in super interfaces Feb 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 5, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 5, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8216324: GetClassMethods is confused by the presence of default methods in super interfaces

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • c06b62e: 8234058: runtime/CompressedOops/CompressedClassPointers.java fails with 'Narrow klass base: 0x0000000000000000' missing from stdout/stderr
  • 43ed001: 8239497: SEGV in EdgeUtils::field_name_symbol(Edge const&)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 5, 2021

Webrevs

@kvergizova
Copy link
Contributor Author

@kvergizova kvergizova commented Feb 5, 2021

/integrate

@openjdk openjdk bot added the sponsor label Feb 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 5, 2021

@kvergizova
Your change (at version a229b60) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Feb 5, 2021

/sponsor

@openjdk openjdk bot closed this Feb 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 5, 2021

@yan-too @kvergizova Since your change was applied there have been 2 commits pushed to the master branch:

  • c06b62e: 8234058: runtime/CompressedOops/CompressedClassPointers.java fails with 'Narrow klass base: 0x0000000000000000' missing from stdout/stderr
  • 43ed001: 8239497: SEGV in EdgeUtils::field_name_symbol(Edge const&)

Your commit was automatically rebased without conflicts.

Pushed as commit 051ffce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Feb 5, 2021
@kvergizova kvergizova deleted the kvergizova:backport-8216324 branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants