Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

8243925: Toolkit#getScreenInsets() returns wrong value on HiDPI screens (Windows) #112

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Feb 8, 2021

Ahem, third attempt to backport this issue. After creating a PR, doing testing, I realized that newly introduced test change required some modifications. It has a preview feature in terms of 13 totally unrelated to the original issue.
Unfortunately, I could not find an easy way to amend a backport commit (routine described for a regular PR seems not working here). So I had to close PR, discard a branch and start anew.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8243925: Toolkit#getScreenInsets() returns wrong value on HiDPI screens (Windows)

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/112/head:pull/112
$ git checkout pull/112

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 8, 2021

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9c415c4d524336157ccaeb780b18d133b19aa527 8243925: Toolkit#getScreenInsets() returns wrong value on HiDPI screens (Windows) Feb 8, 2021
@openjdk
Copy link

openjdk bot commented Feb 8, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 8, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 8, 2021

Webrevs

Copy link
Collaborator

@bae bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed change looks fine to me.

Thanks,
Andrew

@openjdk
Copy link

openjdk bot commented Feb 8, 2021

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8243925: Toolkit#getScreenInsets() returns wrong value on HiDPI screens (Windows)

Reviewed-by: bae

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 8, 2021
@yan-too
Copy link
Collaborator Author

yan-too commented Feb 8, 2021

/integrate

@openjdk openjdk bot closed this Feb 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 8, 2021
@openjdk
Copy link

openjdk bot commented Feb 8, 2021

@yan-too Pushed as commit f7aa8b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the B8243925 branch February 8, 2021 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants