Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8196969: JTreg Failure: serviceability/sa/ClhsdbJstack.java causes NPE #113

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Feb 8, 2021

I'd like to backport 8196969 to 13u for parity with 11u.
The patch applies cleanly.
Tested with tier1; new test fails without the patch, passes with it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8196969: JTreg Failure: serviceability/sa/ClhsdbJstack.java causes NPE

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/113/head:pull/113
$ git checkout pull/113

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 8, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c4f5c4fe9ba9c7ee9f46da309d8bff4ecf771f49 8196969: JTreg Failure: serviceability/sa/ClhsdbJstack.java causes NPE Feb 8, 2021
@openjdk
Copy link

openjdk bot commented Feb 8, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 8, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8196969: JTreg Failure: serviceability/sa/ClhsdbJstack.java causes NPE

Account for serialized null scopes in NMethod

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • bb3bbd0: 8259048: (tz) Upgrade time-zone data to tzdata2020f
  • f7aa8b5: 8243925: Toolkit#getScreenInsets() returns wrong value on HiDPI screens (Windows)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 8, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 8, 2021

Webrevs

@kvergizova
Copy link
Contributor Author

kvergizova commented Feb 9, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 9, 2021
@openjdk
Copy link

openjdk bot commented Feb 9, 2021

@kvergizova
Your change (at version 526b03d) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Feb 9, 2021

/sponsor

@openjdk openjdk bot closed this Feb 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 9, 2021
@openjdk
Copy link

openjdk bot commented Feb 9, 2021

@yan-too @kvergizova Since your change was applied there have been 2 commits pushed to the master branch:

  • bb3bbd0: 8259048: (tz) Upgrade time-zone data to tzdata2020f
  • f7aa8b5: 8243925: Toolkit#getScreenInsets() returns wrong value on HiDPI screens (Windows)

Your commit was automatically rebased without conflicts.

Pushed as commit 962ff98.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8196969 branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants