Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8235829: graal crashes with Zombie.java test #118

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Feb 10, 2021

I'd like to backport JDK-8235829 to 13u for parity with 11u.
The patch doesn't apply cleanly due to minor context difference in management.cpp (JDK-8170299 is not in 13u), reapplied manually.
Tested with tier1.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/118/head:pull/118
$ git checkout pull/118

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 10, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport eb6beeac946ba2070c3549fecb2c8aa5bb56f8f3 8235829: graal crashes with Zombie.java test Feb 10, 2021
@openjdk
Copy link

openjdk bot commented Feb 10, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr labels Feb 10, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 10, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 11, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8235829: graal crashes with Zombie.java test

Start ServiceThread before compiler threads, and run nmethod barriers for zgc before adding to the service thread queues, or posting events from the java thread.

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 9b4784d: 8249251: [dark_mode ubuntu 20.04] The selected menu is not highlighted in GTKLookAndFeel

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Feb 11, 2021
@kvergizova
Copy link
Contributor Author

kvergizova commented Feb 11, 2021

/integrate

@openjdk openjdk bot added the sponsor label Feb 11, 2021
@openjdk
Copy link

openjdk bot commented Feb 11, 2021

@kvergizova
Your change (at version 218816c) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Feb 11, 2021

/sponsor

@openjdk openjdk bot closed this Feb 11, 2021
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Feb 11, 2021
@openjdk
Copy link

openjdk bot commented Feb 11, 2021

@yan-too @kvergizova Since your change was applied there has been 1 commit pushed to the master branch:

  • 9b4784d: 8249251: [dark_mode ubuntu 20.04] The selected menu is not highlighted in GTKLookAndFeel

Your commit was automatically rebased without conflicts.

Pushed as commit b5216aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8235829 branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants