Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249251: [dark_mode ubuntu 20.04] The selected menu is not highlighted in GTKLookAndFeel #119

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Feb 11, 2021

Tried with different WMs. The fix seems working well with SwingSet2; automatic swing tests don't show any regression.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8249251: [dark_mode ubuntu 20.04] The selected menu is not highlighted in GTKLookAndFeel

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/119/head:pull/119
$ git checkout pull/119

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 11, 2021

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport be2a92d8c7365c7aa79a43b53139e2f57fb15390 8249251: [dark_mode ubuntu 20.04] The selected menu is not highlighted in GTKLookAndFeel Feb 11, 2021
@openjdk
Copy link

openjdk bot commented Feb 11, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 11, 2021

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8249251: [dark_mode ubuntu 20.04]  The selected menu is not highlighted in GTKLookAndFeel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 11, 2021
@yan-too
Copy link
Collaborator Author

yan-too commented Feb 11, 2021

/integrate

@mlbridge
Copy link

mlbridge bot commented Feb 11, 2021

Webrevs

@openjdk openjdk bot closed this Feb 11, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 11, 2021
@openjdk
Copy link

openjdk bot commented Feb 11, 2021

@yan-too Pushed as commit 9b4784d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8249251 branch Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant