8242283: Can't start JVM when java home path includes non-ASCII character

[omikhaltsova]

I'd like to backport JDK-8242283 to jdk13u for parity with jdk11u.
It's a partial fix related only to HotSpot. The scope of fixes is the same as for jdk11u. The reasons is the same.
The original (partial) patch applied cleanly.

Tested manually. This patch is applied after JDK-8240197 and it fixes the following scenario for example:
System locale: Chinese (Simplified, China)
Current format: English (United States)
Active code page: 936

Before the patch:
/cygdrive/y/projects/jdk13u-dev-fork/build/windows-x86_64-server-release_中文_/images/jdk/bin
$ ./java -version
Error occurred during initialization of VM
Failed setting boot class path.

After the patch:
/cygdrive/y/projects/jdk13u-dev-fork/build/windows-x86_64-server-release_中文_/images/jdk/bin
$ ./java -version
openjdk version "13.0.7-internal" 2021-04-20
OpenJDK Runtime Environment (build 13.0.7-internal+0-adhoc.omikhaltsova.jdk13u-dev-fork)
OpenJDK 64-Bit Server VM (build 13.0.7-internal+0-adhoc.omikhaltsova.jdk13u-dev-fork, mixed mode, sharing)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8242283: Can't start JVM when java home path includes non-ASCII character

Reviewers

• Yuri Nesterenko (@yan-too - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/120/head:pull/120
$ git checkout pull/120

[bridgekeeper]

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (739ce61)

[omikhaltsova]

/integrate

[openjdk]

@omikhaltsova This PR has not yet been marked as ready for integration.

[yan-too]

I think next time it would be better to, well, not duplicate a rationale to make a fix partial etc. but add at least a short explanation and maybe some link here, too. In this case, a reviewer would have to make less steps.

[openjdk]

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8242283: Can't start JVM when java home path includes non-ASCII character

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 8519133: 8229815: Upgrade Jline to 3.12.1
• 4273ff4: 8243320: Add SSL root certificates to Oracle Root CA program
• c36fb9a: 8243321: Add Entrust root CA - G4 to Oracle Root CA program
• 86ccee1: 8227275: Within native OOM error handling, assertions may hang the process
• 9f7f443: 8241319: WB_GetCodeBlob doesn't have ResourceMark
• b5216aa: 8235829: graal crashes with Zombie.java test
• 9b4784d: 8249251: [dark_mode ubuntu 20.04] The selected menu is not highlighted in GTKLookAndFeel

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[omikhaltsova]

/integrate

[openjdk]

@omikhaltsova
Your change (at version 739ce61) is now ready to be sponsored by a Committer.

[yan-too]

/sponsor

[openjdk]

@yan-too @omikhaltsova Since your change was applied there have been 7 commits pushed to the master branch:

• 8519133: 8229815: Upgrade Jline to 3.12.1
• 4273ff4: 8243320: Add SSL root certificates to Oracle Root CA program
• c36fb9a: 8243321: Add Entrust root CA - G4 to Oracle Root CA program
• 86ccee1: 8227275: Within native OOM error handling, assertions may hang the process
• 9f7f443: 8241319: WB_GetCodeBlob doesn't have ResourceMark
• b5216aa: 8235829: graal crashes with Zombie.java test
• 9b4784d: 8249251: [dark_mode ubuntu 20.04] The selected menu is not highlighted in GTKLookAndFeel

Your commit was automatically rebased without conflicts.

Pushed as commit c229f3c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.