Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242030: Wrong package declarations in jline classes after JDK-8241598 #126

Closed
wants to merge 1 commit into from

Conversation

@kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Feb 12, 2021

I'd like to backport JDK-8242030 to 13u as follow-up fix for JDK-8241598 that is already included to 13u.
The patch applies cleanly.
Tested with tier1 and jshell tier2 tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8242030: Wrong package declarations in jline classes after JDK-8241598

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/126/head:pull/126
$ git checkout pull/126

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 12, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 746d28d110c8b63007491560d6f5ba3a337ed9dd 8242030: Wrong package declarations in jline classes after JDK-8241598 Feb 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8242030: Wrong package declarations in jline classes after JDK-8241598

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 12, 2021

Webrevs

Loading

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Feb 19, 2021

Katya is Committer now; let see if the census is reread on every occasion... (otherwise the new status would work for the new PRs)

Loading

@kvergizova
Copy link
Contributor Author

@kvergizova kvergizova commented Feb 19, 2021

/integrate

Loading

@openjdk openjdk bot closed this Feb 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 19, 2021

@kvergizova Pushed as commit f9a04a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@kvergizova kvergizova deleted the backport-8242030 branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants