8198540: Dynalink leaks memory when generating type converters

[szegedi]

I would like to backport JDK-8198540 to 13u.

The patch doesn't apply cleanly due to minor context differences, namely that JDK-8251538 is not in 13u. This was a purely code refactoring task, which among other things refactored some anonymous inner classes in TypeConverterFactory.java and ClassMap.java to lambdas. All the lines that failed to apply cleanly were deletes, so after this change these differences no longer even exist.

Additionally, 13u did not have running of tests in test/jdk/jdk/dynalink enabled as part of the jdk_other test group, so a relevant single line of JDK-8252124 was also added to test/jdk/TEST.groups to enable the two tests that are part of this change to run.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8198540: Dynalink leaks memory when generating type converters

Reviewers

• Yuri Nesterenko (@yan-too - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/127/head:pull/127
$ git checkout pull/127

[bridgekeeper]

👋 Welcome back attila! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (f017140)

[yan-too]

There should be a better reviewer but time is nigh: ship it!

[openjdk]

@szegedi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8198540: Dynalink leaks memory when generating type converters

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 335890f: 8260308: Update LogCompilation junit to 4.13.1
• 64f6dfa: 8232905: JFR fails with assertion: assert(t->unflushed_size() == 0) failed: invariant
• c668a0c: 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines
• a3174be: 8245283: JFR: Can't handle constant dynamic used by Jacoco agent
• 422eb19: 8243559: Remove root certificates with 1024-bit keys
• a71cc1d: 8259707: LDAP channel binding does not work with StartTLS extension
• 72d9bf5: 8246027: Minimal fastdebug build broken after JDK-8245801
• 93aca5f: 8245801: StressRecompilation triggers assert "redundunt OSR recompilation detected. memory leak in CodeCache!"
• f9a04a4: 8242030: Wrong package declarations in jline classes after JDK-8241598

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[szegedi]

Thank you @yan-too ! I'll shortly follow it up with a backport of the change that makes the tests in this PR more reliable.

[szegedi]

/integrate

[openjdk]

@szegedi Since your change was applied there have been 9 commits pushed to the master branch:

• 335890f: 8260308: Update LogCompilation junit to 4.13.1
• 64f6dfa: 8232905: JFR fails with assertion: assert(t->unflushed_size() == 0) failed: invariant
• c668a0c: 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines
• a3174be: 8245283: JFR: Can't handle constant dynamic used by Jacoco agent
• 422eb19: 8243559: Remove root certificates with 1024-bit keys
• a71cc1d: 8259707: LDAP channel binding does not work with StartTLS extension
• 72d9bf5: 8246027: Minimal fastdebug build broken after JDK-8245801
• 93aca5f: 8245801: StressRecompilation triggers assert "redundunt OSR recompilation detected. memory leak in CodeCache!"
• f9a04a4: 8242030: Wrong package declarations in jline classes after JDK-8241598

Your commit was automatically rebased without conflicts.

Pushed as commit 26f7e6f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.