Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8243559: Remove root certificates with 1024-bit keys #130

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Feb 20, 2021

I'd like to port this fix to 13u, too. Applied clean, all relevant tests run as expected.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8243559: Remove root certificates with 1024-bit keys

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/130/head:pull/130
$ git checkout pull/130

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 20, 2021

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport dbfeb90d3a50b6bb0966e44164e6cf199e34cf47 8243559: Remove root certificates with 1024-bit keys Feb 20, 2021
@openjdk
Copy link

openjdk bot commented Feb 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 20, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 20, 2021

Webrevs

bae
bae approved these changes Feb 20, 2021
Copy link
Collaborator

@bae bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine to me.

@openjdk
Copy link

openjdk bot commented Feb 20, 2021

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8243559: Remove root certificates with 1024-bit keys

Reviewed-by: bae

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 20, 2021
@yan-too
Copy link
Collaborator Author

yan-too commented Feb 25, 2021

/integrate

@openjdk openjdk bot closed this Feb 25, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 25, 2021
@openjdk
Copy link

openjdk bot commented Feb 25, 2021

@yan-too Since your change was applied there has been 1 commit pushed to the master branch:

  • a71cc1d: 8259707: LDAP channel binding does not work with StartTLS extension

Your commit was automatically rebased without conflicts.

Pushed as commit 422eb19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8243559 branch April 22, 2021 11:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants