Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259707: LDAP channel binding does not work with StartTLS extension #131

Closed
wants to merge 1 commit into from
Closed

8259707: LDAP channel binding does not work with StartTLS extension #131

wants to merge 1 commit into from

Conversation

@alexeybakhtin
Copy link
Contributor

@alexeybakhtin alexeybakhtin commented Feb 24, 2021

I'd like to port this fix to 13u. Applied clean, all relevant tests run as expected.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259707: LDAP channel binding does not work with StartTLS extension

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/131/head:pull/131
$ git checkout pull/131

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 24, 2021

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 874aef4a8f7ca503591e21333c092d1a969bc5a8 8259707: LDAP channel binding does not work with StartTLS extension Feb 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 24, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 24, 2021

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8259707: LDAP channel binding does not work with StartTLS extension

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 72d9bf5: 8246027: Minimal fastdebug build broken after JDK-8245801
  • 93aca5f: 8245801: StressRecompilation triggers assert "redundunt OSR recompilation detected. memory leak in CodeCache!"
  • f9a04a4: 8242030: Wrong package declarations in jline classes after JDK-8241598

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 24, 2021

Webrevs

@alexeybakhtin
Copy link
Contributor Author

@alexeybakhtin alexeybakhtin commented Feb 24, 2021

/integrate

@openjdk openjdk bot added the sponsor label Feb 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 24, 2021

@alexeybakhtin
Your change (at version 2119885) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Feb 24, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Feb 24, 2021

@yan-too @alexeybakhtin Since your change was applied there have been 3 commits pushed to the master branch:

  • 72d9bf5: 8246027: Minimal fastdebug build broken after JDK-8245801
  • 93aca5f: 8245801: StressRecompilation triggers assert "redundunt OSR recompilation detected. memory leak in CodeCache!"
  • f9a04a4: 8242030: Wrong package declarations in jline classes after JDK-8241598

Your commit was automatically rebased without conflicts.

Pushed as commit a71cc1d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants