Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8245283: JFR: Can't handle constant dynamic used by Jacoco agent #132

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Feb 25, 2021

I'd like to backport JDK-8245283 to 13u for parity with 11u.
The patch applies cleanly.
Tested with tier1 and jdk/jfr tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8245283: JFR: Can't handle constant dynamic used by Jacoco agent

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/132/head:pull/132
$ git checkout pull/132

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 25, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2bfc64ad1f590795f3a507fc8c099a665855a68b 8245283: JFR: Can't handle constant dynamic used by Jacoco agent Feb 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 25, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 25, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8245283: JFR: Can't handle constant dynamic used by Jacoco agent

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 422eb19: 8243559: Remove root certificates with 1024-bit keys

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Feb 25, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 25, 2021

Webrevs

@kvergizova
Copy link
Contributor Author

@kvergizova kvergizova commented Feb 25, 2021

/integrate

@openjdk openjdk bot closed this Feb 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 25, 2021

@kvergizova Since your change was applied there has been 1 commit pushed to the master branch:

  • 422eb19: 8243559: Remove root certificates with 1024-bit keys

Your commit was automatically rebased without conflicts.

Pushed as commit a3174be.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8245283 branch Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant