Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257746: Regression introduced with JDK-8250984 - memory might be null in some machines #133

Closed
wants to merge 1 commit into from

Conversation

@kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Mar 1, 2021

I'd like to backport JDK-8257746 to 13u for parity with 11u.
The patch doesn't apply cleanly since 13u doesn't have cgroups v2 support (JDK-8231111), so it reapplied manually to similar places in cgroupv1/Metrics.java.
Tested with tier1 and container tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257746: Regression introduced with JDK-8250984 - memory might be null in some machines

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/133/head:pull/133
$ git checkout pull/133

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 1, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport abc4300de9c7a298c359fb585d3b0570a98df5cb 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines Mar 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 1, 2021

This backport pull request has now been updated with issue from the original commit.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 1, 2021

Webrevs

jerboaa
jerboaa approved these changes Mar 1, 2021
Copy link

@jerboaa jerboaa left a comment

Looks fine.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 1, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8257746: Regression introduced with JDK-8250984 - memory might be null in some machines

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 1, 2021
@kvergizova
Copy link
Contributor Author

@kvergizova kvergizova commented Mar 2, 2021

/integrate

@openjdk openjdk bot closed this Mar 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 2, 2021

@kvergizova Pushed as commit c668a0c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8257746 branch Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants