Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233880: Support compilers with multi-digit major version numbers #137

Closed
wants to merge 1 commit into from

Conversation

@omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented Mar 4, 2021

I'd like to backport JDK-8233880 to jdk13u for parity with jdk11u.
The original patch applied cleanly.
Checked this configure warning fix manually on Ubuntu 20.04 with gcc 10.2.0.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8233880: Support compilers with multi-digit major version numbers

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/137/head:pull/137
$ git checkout pull/137

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 4, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7dafe378d3b4fbbb39d1bbfdb50cc655ebf633bd 8233880: Support compilers with multi-digit major version numbers Mar 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 4, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 4, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8233880: Support compilers with multi-digit major version numbers

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 4, 2021

Webrevs

@omikhaltsova
Copy link
Contributor Author

@omikhaltsova omikhaltsova commented Mar 4, 2021

/integrate

1 similar comment
@yan-too
Copy link
Collaborator

@yan-too yan-too commented Mar 4, 2021

/integrate

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Mar 4, 2021

/sponsor

@openjdk openjdk bot added the sponsor label Mar 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 4, 2021

@omikhaltsova
Your change (at version a60545e) is now ready to be sponsored by a Committer.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 4, 2021

@yan-too Only the author (@omikhaltsova) is allowed to issue the integrate command. As this PR is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

@openjdk openjdk bot closed this Mar 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 4, 2021

@yan-too @omikhaltsova Pushed as commit 2f2f2de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@omikhaltsova omikhaltsova deleted the omikhaltsova:backport-7dafe378 branch Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants