Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259949: x86 32-bit build fails when -fcf-protection is passed in the compiler flags #140

Closed
wants to merge 1 commit into from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Mar 4, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259949: x86 32-bit build fails when -fcf-protection is passed in the compiler flags

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/140/head:pull/140
$ git checkout pull/140

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2021

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0785147460934ee2aa413ab7872837094824bd3d 8259949: x86 32-bit build fails when -fcf-protection is passed in the compiler flags Mar 4, 2021
@openjdk
Copy link

openjdk bot commented Mar 4, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 4, 2021

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8259949: x86 32-bit build fails when -fcf-protection is passed in the compiler flags

Use -march=i686 instead of -march=i586 if -fcf-protection is passed to the build as CMOV is required

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Mar 4, 2021
@gnu-andrew
Copy link
Member Author

gnu-andrew commented Mar 4, 2021

/integrate

@openjdk openjdk bot closed this Mar 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 4, 2021
@openjdk
Copy link

openjdk bot commented Mar 4, 2021

@gnu-andrew Pushed as commit b8d5fcb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Mar 4, 2021

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant