Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8240711: TestJstatdPort.java failed due to "ExportException: Port already in use:" #141

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented Mar 5, 2021

I'd like to backport JDK-8240711 to jdk13u for parity with jdk11u.
The original patch applied cleanly.
sun/tools/jstatd tests passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8240711: TestJstatdPort.java failed due to "ExportException: Port already in use:"

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/141/head:pull/141
$ git checkout pull/141

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b70ef0d2e256085b48f8d5b0f131bca89b699609 8240711: TestJstatdPort.java failed due to "ExportException: Port already in use:" Mar 5, 2021
@openjdk
Copy link

openjdk bot commented Mar 5, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 5, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8240711: TestJstatdPort.java failed due to "ExportException: Port already in use:"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 71ed1cd: 8261483: jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java failed with "AssertionError: Should have GCd a method handle by now"
  • 54a8465: 8253476: TestUseContainerSupport.java fails on some Linux kernels w/o swap limit capabilities
  • b8d5fcb: 8259949: x86 32-bit build fails when -fcf-protection is passed in the compiler flags
  • fd2aac7: 8260356: (tz) Upgrade time-zone data to tzdata2021a
  • 2f2f2de: 8233880: Support compilers with multi-digit major version numbers
  • 26f7e6f: 8198540: Dynalink leaks memory when generating type converters
  • 335890f: 8260308: Update LogCompilation junit to 4.13.1
  • 64f6dfa: 8232905: JFR fails with assertion: assert(t->unflushed_size() == 0) failed: invariant
  • c668a0c: 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 5, 2021
@omikhaltsova
Copy link
Contributor Author

omikhaltsova commented Mar 5, 2021

/integrate

@mlbridge
Copy link

mlbridge bot commented Mar 5, 2021

Webrevs

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 5, 2021
@openjdk
Copy link

openjdk bot commented Mar 5, 2021

@omikhaltsova
Your change (at version fa16547) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Mar 5, 2021

/sponsor

@openjdk openjdk bot closed this Mar 5, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 5, 2021
@openjdk
Copy link

openjdk bot commented Mar 5, 2021

@yan-too @omikhaltsova Since your change was applied there have been 9 commits pushed to the master branch:

  • 71ed1cd: 8261483: jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java failed with "AssertionError: Should have GCd a method handle by now"
  • 54a8465: 8253476: TestUseContainerSupport.java fails on some Linux kernels w/o swap limit capabilities
  • b8d5fcb: 8259949: x86 32-bit build fails when -fcf-protection is passed in the compiler flags
  • fd2aac7: 8260356: (tz) Upgrade time-zone data to tzdata2021a
  • 2f2f2de: 8233880: Support compilers with multi-digit major version numbers
  • 26f7e6f: 8198540: Dynalink leaks memory when generating type converters
  • 335890f: 8260308: Update LogCompilation junit to 4.13.1
  • 64f6dfa: 8232905: JFR fails with assertion: assert(t->unflushed_size() == 0) failed: invariant
  • c668a0c: 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines

Your commit was automatically rebased without conflicts.

Pushed as commit 7d0aaf1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@omikhaltsova omikhaltsova deleted the backport-b70ef0d2 branch Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants