Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8250911: [windows] os::pd_map_memory error detection broken #147

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Mar 12, 2021

I'd like to backport JDK-8250911 to 13u for parity with 11u.
The patch applies cleanly.
Tested with tier1.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8250911: [windows] os::pd_map_memory error detection broken

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/147/head:pull/147
$ git checkout pull/147

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport aab365f7463014be658dd55626f1628048642a13 8250911: [windows] os::pd_map_memory error detection broken Mar 12, 2021
@openjdk
Copy link

openjdk bot commented Mar 12, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 12, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8250911: [windows] os::pd_map_memory error detection broken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 325657a: 8246707: (sc) SocketChannel.read/write throws AsynchronousCloseException on closed channel

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 12, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 12, 2021

Webrevs

@kvergizova
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Mar 15, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 15, 2021
@openjdk
Copy link

openjdk bot commented Mar 15, 2021

@kvergizova Since your change was applied there has been 1 commit pushed to the master branch:

  • 325657a: 8246707: (sc) SocketChannel.read/write throws AsynchronousCloseException on closed channel

Your commit was automatically rebased without conflicts.

Pushed as commit d7a63fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8250911 branch March 17, 2021 10:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant