Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255625: AArch64: Implement Base64.encodeBlock accelerator/intrinsic #149

Closed
wants to merge 1 commit into from
Closed

8255625: AArch64: Implement Base64.encodeBlock accelerator/intrinsic #149

wants to merge 1 commit into from

Conversation

@snazarkin
Copy link

@snazarkin snazarkin commented Mar 17, 2021

I'd like to backport JDK-8257414 to jdk13u for performance improvement. The patch is not applied cleanly due to miss of JDK-8224974. The following block need to be applied manually
if (UseBASE64Intrinsics) {
StubRoutines::_base64_encodeBlock = generate_base64_encodeBlock();
}

Passed tier1 and verify performance change with new test.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8255625: AArch64: Implement Base64.encodeBlock accelerator/intrinsic

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/149/head:pull/149
$ git checkout pull/149

To update a local copy of the PR:
$ git checkout pull/149
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/149/head

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 17, 2021

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8638cd9acf5c33612eaf82ae3219f68456ea9621 8255625: AArch64: Implement Base64.encodeBlock accelerator/intrinsic Mar 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2021

@snazarkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8255625: AArch64: Implement Base64.encodeBlock accelerator/intrinsic

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 17, 2021

Webrevs

@snazarkin
Copy link
Author

@snazarkin snazarkin commented Mar 17, 2021

/integrate

@openjdk openjdk bot added the sponsor label Mar 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2021

@snazarkin
Your change (at version 4066380) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Mar 17, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2021

@yan-too @snazarkin Pushed as commit ebea17d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@snazarkin snazarkin deleted the 8255625-backport branch Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants