Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8261022: Fix incorrect result of Math.abs() with char type #152

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Mar 18, 2021

I'd like to backport JDK-8261022 to 13u for parity with 11u.
The patch applies cleanly, but requires some modification due to absence of VectorNode::is_shift_opcode in 13u (JDK-8257625 is not in 13u), replaced by similar VectorNode::is_shift.
Tested with tier1; new test fails without the patch, passes with it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261022: Fix incorrect result of Math.abs() with char type

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/152/head:pull/152
$ git checkout pull/152

To update a local copy of the PR:
$ git checkout pull/152
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/152/head

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 18, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7a2db858e0e81f2ba17c3554386bb6a833318b3d 8261022: Fix incorrect result of Math.abs() with char type Mar 18, 2021
@openjdk
Copy link

openjdk bot commented Mar 18, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 18, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 18, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 18, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261022: Fix incorrect result of Math.abs() with char type

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • a117b8b: 8263425: AArch64: two potential bugs in C1 LIRGenerator::generate_address()
  • ebea17d: 8255625: AArch64: Implement Base64.encodeBlock accelerator/intrinsic
  • 5850c58: 8257414: Drag n Drop target area is wrong on high DPI systems

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 18, 2021
@kvergizova
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Mar 18, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 18, 2021
@openjdk
Copy link

openjdk bot commented Mar 18, 2021

@kvergizova Since your change was applied there have been 3 commits pushed to the master branch:

  • a117b8b: 8263425: AArch64: two potential bugs in C1 LIRGenerator::generate_address()
  • ebea17d: 8255625: AArch64: Implement Base64.encodeBlock accelerator/intrinsic
  • 5850c58: 8257414: Drag n Drop target area is wrong on high DPI systems

Your commit was automatically rebased without conflicts.

Pushed as commit ff29b0b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8261022 branch March 30, 2021 17:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants