Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8237977: Further update javax/net/ssl/compatibility/Compatibility.java #153

Closed
wants to merge 1 commit into from

Conversation

@omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented Mar 18, 2021

I'd like to backport JDK-8237977 to jdk13u for parity with jdk11u.
The original patch applied cleanly.
All regular tests passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8237977: Further update javax/net/ssl/compatibility/Compatibility.java

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/153/head:pull/153
$ git checkout pull/153

To update a local copy of the PR:
$ git checkout pull/153
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/153/head

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 18, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 60fae7797438ea0e7d6e4354af0f8406fab2b16c 8237977: Further update javax/net/ssl/compatibility/Compatibility.java Mar 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8237977: Further update javax/net/ssl/compatibility/Compatibility.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • e53c560: 8240295: hs_err elapsed time in seconds is not accurate enough
  • 6d32c41: 8237950: C2 compilation fails with "Live Node limit exceeded limit" during ConvI2L::Ideal optimization
  • 3519e53: 8244573: java.lang.ArrayIndexOutOfBoundsException thrown for malformed class file
  • 17c982e: 8253409: Double-rounding possibility in float fma

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 18, 2021

Webrevs

Loading

@omikhaltsova
Copy link
Contributor Author

@omikhaltsova omikhaltsova commented Mar 19, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Mar 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 19, 2021

@omikhaltsova
Your change (at version f01e966) is now ready to be sponsored by a Committer.

Loading

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Mar 22, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 22, 2021

@yan-too @omikhaltsova Since your change was applied there have been 4 commits pushed to the master branch:

  • e53c560: 8240295: hs_err elapsed time in seconds is not accurate enough
  • 6d32c41: 8237950: C2 compilation fails with "Live Node limit exceeded limit" during ConvI2L::Ideal optimization
  • 3519e53: 8244573: java.lang.ArrayIndexOutOfBoundsException thrown for malformed class file
  • 17c982e: 8253409: Double-rounding possibility in float fma

Your commit was automatically rebased without conflicts.

Pushed as commit 44dfa89.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@omikhaltsova omikhaltsova deleted the backport-60fae779 branch May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants