Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253409: Double-rounding possibility in float fma #154

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Mar 19, 2021

I'd like to backport JDK-8253409 to 13u for parity with 11u.
The patch applies cleanly.
Tested with tier1; new test fails without the patch, passes with it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253409: Double-rounding possibility in float fma

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/154/head:pull/154
$ git checkout pull/154

To update a local copy of the PR:
$ git checkout pull/154
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/154/head

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 19, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e5304b3a994b1e291e4ac5258f473dd7874f163f 8253409: Double-rounding possibility in float fma Mar 19, 2021
@openjdk
Copy link

openjdk bot commented Mar 19, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 19, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8253409: Double-rounding possibility in float fma

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 19, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 19, 2021

Webrevs

@kvergizova
Copy link
Contributor Author

kvergizova commented Mar 19, 2021

/integrate

@openjdk openjdk bot closed this Mar 19, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 19, 2021
@openjdk
Copy link

openjdk bot commented Mar 19, 2021

@kvergizova Pushed as commit 17c982e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8253409 branch Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant