Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8234779: Provide idiom for declaring classes noncopyable #158

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented Mar 22, 2021

I'd like to backport JDK-8234779 to jdk13u for parity with jdk11u.
The original patch applied not cleanly.

The merge was required for the following 6 files:

  1. due to the context changes in the includes of headers part:
    src/hotspot/share/utilities/bitMap.hpp
    src/hotspot/share/gc/z/zList.hpp
  2. due to no definition of such a class (PlatformMutex):
    src/hotspot/os/windows/os_windows.hpp
    src/hotspot/os/solaris/os_solaris.hpp
    src/hotspot/os/posix/os_posix.hpp
  3. due to the context changes:
    src/hotspot/share/gc/shared/ptrQueue.hpp

All regular tests passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8234779: Provide idiom for declaring classes noncopyable

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/158/head:pull/158
$ git checkout pull/158

To update a local copy of the PR:
$ git checkout pull/158
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/158/head

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 22, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 577e87e5b27a3f4c590258b370a42c511f724cbc 8234779: Provide idiom for declaring classes noncopyable Mar 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 22, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr labels Mar 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 22, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Mar 22, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8234779: Provide idiom for declaring classes noncopyable

Add NONCOPYABLE macro and uses.

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 44dfa89: 8237977: Further update javax/net/ssl/compatibility/Compatibility.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 22, 2021
@omikhaltsova
Copy link
Contributor Author

@omikhaltsova omikhaltsova commented Mar 22, 2021

/integrate

@openjdk openjdk bot added the sponsor label Mar 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 22, 2021

@omikhaltsova
Your change (at version 574ae25) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Mar 22, 2021

/sponsor

@openjdk openjdk bot closed this Mar 22, 2021
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Mar 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 22, 2021

@yan-too @omikhaltsova Since your change was applied there has been 1 commit pushed to the master branch:

  • 44dfa89: 8237977: Further update javax/net/ssl/compatibility/Compatibility.java

Your commit was automatically rebased without conflicts.

Pushed as commit 3186873.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@omikhaltsova omikhaltsova deleted the backport-577e87e5 branch May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants