Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263996: Fix build on 13u after JDK-8234779 backport #160

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented Mar 22, 2021

I would like to partialy revert changes made by backport of JDK-8234779 to jdk13u: to remove restriction for copying objects from PlatformMonitor class due to the builds failure.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263996: Fix build on 13u after JDK-8234779 backport

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/160/head:pull/160
$ git checkout pull/160

To update a local copy of the PR:
$ git checkout pull/160
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/160/head

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 22, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 22, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Mar 22, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8263996: Fix build on 13u after JDK-8234779 backport

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 22, 2021
@omikhaltsova
Copy link
Contributor Author

@omikhaltsova omikhaltsova commented Mar 22, 2021

/integrate

@openjdk openjdk bot added the sponsor label Mar 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 22, 2021

@omikhaltsova
Your change (at version 5c9d27c) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Mar 22, 2021

/sponsor

@openjdk openjdk bot closed this Mar 22, 2021
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Mar 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 22, 2021

@yan-too @omikhaltsova Pushed as commit c37cdb3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants