New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8256682: JDK-8202343 is incomplete #167
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks fine to me.
Thanks,
Andrew
@yan-too This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
/integrate |
Need to fix this test after 8202343, a small change
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/167/head:pull/167
$ git checkout pull/167
Update a local copy of the PR:
$ git checkout pull/167
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/167/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 167
View PR using the GUI difftool:
$ git pr show -t 167
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/167.diff