Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m #169

Closed
wants to merge 1 commit into from

Conversation

@VladimirKempik
Copy link
Contributor

@VladimirKempik VladimirKempik commented Apr 6, 2021

Backport to jdk13u-dev.
Applies almost clean, few gmk files had different filename and few copyright year issues.
Original commit - VladimirKempik/jdk@4a8b5c1


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
  • JDK-8257860: [macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/169/head:pull/169
$ git checkout pull/169

Update a local copy of the PR:
$ git checkout pull/169
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/169/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 169

View PR using the GUI difftool:
$ git pr show -t 169

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/169.diff

…mpl.m 8257860: [macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m

Backport-of: 4a8b5c1
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 6, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 6, 2021
@VladimirKempik
Copy link
Contributor Author

@VladimirKempik VladimirKempik commented Apr 6, 2021

/clean

@openjdk
Copy link

@openjdk openjdk bot commented Apr 6, 2021

@openjdk
Copy link

@openjdk openjdk bot commented Apr 6, 2021

@VladimirKempik The label backport is not a valid label. These labels are valid:

@VladimirKempik
Copy link
Contributor Author

@VladimirKempik VladimirKempik commented Apr 6, 2021

/label add backport

@openjdk
Copy link

@openjdk openjdk bot commented Apr 6, 2021

@VladimirKempik The label backport is not a valid label. These labels are valid:

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 6, 2021

Webrevs

@VladimirKempik VladimirKempik changed the title 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m Backport-4a8b5c1602789e95457cbb080a64c56edaf81051 Apr 7, 2021
@VladimirKempik VladimirKempik changed the title Backport-4a8b5c1602789e95457cbb080a64c56edaf81051 Backport 4a8b5c1602789e95457cbb080a64c56edaf81051 Apr 7, 2021
@openjdk openjdk bot removed the rfr label Apr 7, 2021
@openjdk openjdk bot changed the title Backport 4a8b5c1602789e95457cbb080a64c56edaf81051 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m Apr 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2021

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added the backport label Apr 7, 2021
@VladimirKempik
Copy link
Contributor Author

@VladimirKempik VladimirKempik commented Apr 7, 2021

/clean

@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2021

@VladimirKempik @VladimirKempik this backport pull request is now marked as clean

yan-too
yan-too approved these changes Apr 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
8257860: [macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 7, 2021
@VladimirKempik
Copy link
Contributor Author

@VladimirKempik VladimirKempik commented Apr 7, 2021

/integrate

@openjdk openjdk bot closed this Apr 7, 2021
@openjdk openjdk bot added integrated and removed ready labels Apr 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2021

@VladimirKempik Pushed as commit 9d0d73e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Apr 7, 2021
@VladimirKempik VladimirKempik deleted the JDK-8257858 branch Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants