Navigation Menu

Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m #169

Closed
wants to merge 1 commit into from
Closed

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Apr 6, 2021

Backport to jdk13u-dev.
Applies almost clean, few gmk files had different filename and few copyright year issues.
Original commit - VladimirKempik/jdk@4a8b5c1


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
  • JDK-8257860: [macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/169/head:pull/169
$ git checkout pull/169

Update a local copy of the PR:
$ git checkout pull/169
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/169/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 169

View PR using the GUI difftool:
$ git pr show -t 169

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/169.diff

…mpl.m 8257860: [macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m

Backport-of: 4a8b5c1
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 6, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 6, 2021
@VladimirKempik
Copy link
Author

/clean

@openjdk
Copy link

openjdk bot commented Apr 6, 2021

@VladimirKempik @VladimirKempik can only mark backport pull requests as clean

@openjdk
Copy link

openjdk bot commented Apr 6, 2021

@VladimirKempik The label backport is not a valid label. These labels are valid:

@VladimirKempik
Copy link
Author

/label add backport

@openjdk
Copy link

openjdk bot commented Apr 6, 2021

@VladimirKempik The label backport is not a valid label. These labels are valid:

@mlbridge
Copy link

mlbridge bot commented Apr 6, 2021

Webrevs

@VladimirKempik VladimirKempik changed the title 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m Backport-4a8b5c1602789e95457cbb080a64c56edaf81051 Apr 7, 2021
@VladimirKempik VladimirKempik changed the title Backport-4a8b5c1602789e95457cbb080a64c56edaf81051 Backport 4a8b5c1602789e95457cbb080a64c56edaf81051 Apr 7, 2021
@openjdk openjdk bot removed the rfr Pull request is ready for review label Apr 7, 2021
@openjdk openjdk bot changed the title Backport 4a8b5c1602789e95457cbb080a64c56edaf81051 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m Apr 7, 2021
@openjdk
Copy link

openjdk bot commented Apr 7, 2021

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added the backport label Apr 7, 2021
@VladimirKempik
Copy link
Author

/clean

@openjdk openjdk bot added rfr Pull request is ready for review clean labels Apr 7, 2021
@openjdk
Copy link

openjdk bot commented Apr 7, 2021

@VladimirKempik @VladimirKempik this backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Apr 7, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
8257860: [macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 7, 2021
@VladimirKempik
Copy link
Author

/integrate

@openjdk openjdk bot closed this Apr 7, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Apr 7, 2021
@openjdk
Copy link

openjdk bot commented Apr 7, 2021

@VladimirKempik Pushed as commit 9d0d73e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Apr 7, 2021
@VladimirKempik VladimirKempik deleted the JDK-8257858 branch April 7, 2021 12:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants