Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8240487: Cleanup whitespace in .cc, .hh, .m, and .mm files #172

Conversation

@VladimirKempik
Copy link
Contributor

@VladimirKempik VladimirKempik commented Apr 7, 2021

Clean backport from 15u-dev to 13u-dev.
Backport from 17 to 15 wasn't clean, review - openjdk/jdk15u-dev#8


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8240487: Cleanup whitespace in .cc, .hh, .m, and .mm files

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/172/head:pull/172
$ git checkout pull/172

Update a local copy of the PR:
$ git checkout pull/172
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/172/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 172

View PR using the GUI difftool:
$ git pr show -t 172

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/172.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 7, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c32923e06fc94c2a2ad8b9dd803aad1ed5386505 8240487: Cleanup whitespace in .cc, .hh, .m, and .mm files Apr 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2021

This backport pull request has now been updated with issue from the original commit.

@VladimirKempik
Copy link
Contributor Author

@VladimirKempik VladimirKempik commented Apr 7, 2021

/clean

@openjdk openjdk bot added the clean label Apr 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2021

@VladimirKempik @VladimirKempik this backport pull request is now marked as clean

@yan-too
yan-too approved these changes Apr 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8240487: Cleanup whitespace in .cc, .hh, .m, and .mm files

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 4d5f2ab: 8261585: Restore HandleArea used in Deoptimization::uncommon_trap

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 7, 2021

Webrevs

@VladimirKempik
Copy link
Contributor Author

@VladimirKempik VladimirKempik commented Apr 7, 2021

/integrate

@openjdk openjdk bot closed this Apr 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2021

@VladimirKempik Since your change was applied there has been 1 commit pushed to the master branch:

  • 4d5f2ab: 8261585: Restore HandleArea used in Deoptimization::uncommon_trap

Your commit was automatically rebased without conflicts.

Pushed as commit 98baf88.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@VladimirKempik VladimirKempik deleted the VladimirKempik:backport-e2453498fb336430a80bdb38559942e3292cf18a branch Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants