Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259343: [macOS] Update JNI error handling in Cocoa code. #175

Closed
wants to merge 1 commit into from

Conversation

@VladimirKempik
Copy link
Contributor

@VladimirKempik VladimirKempik commented Apr 8, 2021

clean backport from jdk15 to jdk13, only gmk file needed to be renamed.

not a clean backport from 17 to 13.

jdk15u review - openjdk/jdk15u-dev#10


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259343: [macOS] Update JNI error handling in Cocoa code.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/175/head:pull/175
$ git checkout pull/175

Update a local copy of the PR:
$ git checkout pull/175
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/175/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 175

View PR using the GUI difftool:
$ git pr show -t 175

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/175.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 8, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d6a2105b5c9b44c04cac7385756ec9924c1310ab 8259343: [macOS] Update JNI error handling in Cocoa code. Apr 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 8, 2021

This backport pull request has now been updated with issue from the original commit.

@VladimirKempik
Copy link
Contributor Author

@VladimirKempik VladimirKempik commented Apr 8, 2021

/clean

@openjdk openjdk bot added the clean label Apr 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 8, 2021

@VladimirKempik @VladimirKempik this backport pull request is now marked as clean

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 8, 2021

Webrevs

@yan-too
yan-too approved these changes Apr 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 8, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8259343: [macOS] Update JNI error handling in Cocoa code.

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 8, 2021
@VladimirKempik
Copy link
Contributor Author

@VladimirKempik VladimirKempik commented Apr 8, 2021

/integrate

@openjdk openjdk bot closed this Apr 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 8, 2021

@VladimirKempik Pushed as commit cdb993e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@VladimirKempik VladimirKempik deleted the VladimirKempik:JDK-8259343 branch Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants