Navigation Menu

Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8259232: Bad JNI lookup during printing #181

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented Apr 15, 2021

I'd like to backport JDK-8259232 to jdk13u for parity with jdk11u.
The original patch applied cleanly.
Tested via jtreg with test/jdk/java/awt/print/bug8023392 pointed in the issue.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/181/head:pull/181
$ git checkout pull/181

Update a local copy of the PR:
$ git checkout pull/181
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/181/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 181

View PR using the GUI difftool:
$ git pr show -t 181

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/181.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 15, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 940b053065de788e44ef0d7f6fab901f8f0dfb40 8259232: Bad JNI lookup during printing Apr 15, 2021
@openjdk
Copy link

openjdk bot commented Apr 15, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 15, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8259232: Bad JNI lookup during printing

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 15, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 15, 2021

Webrevs

@omikhaltsova
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 15, 2021
@openjdk
Copy link

openjdk bot commented Apr 15, 2021

@omikhaltsova
Your change (at version 00cc370) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Apr 15, 2021

/sponsor

@openjdk openjdk bot closed this Apr 15, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 15, 2021
@openjdk
Copy link

openjdk bot commented Apr 15, 2021

@yan-too @omikhaltsova Pushed as commit c32180e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@omikhaltsova omikhaltsova deleted the backport-8259232 branch May 20, 2021 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants