Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8244853: The static build of libextnet is missing the JNI_OnLoad_extnet function #182

Closed
wants to merge 1 commit into from

Conversation

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Apr 15, 2021

I'd like to port this fix for general alignment with other release trains. The patch goes clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8244853: The static build of libextnet is missing the JNI_OnLoad_extnet function

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/182/head:pull/182
$ git checkout pull/182

Update a local copy of the PR:
$ git checkout pull/182
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/182/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 182

View PR using the GUI difftool:
$ git pr show -t 182

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/182.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 15, 2021

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3d50f242c2172c05b74e533962195bc8d9ea2997 8244853: The static build of libextnet is missing the JNI_OnLoad_extnet function Apr 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 15, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 15, 2021

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8244853: The static build of libextnet is missing the JNI_OnLoad_extnet function

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • c32180e: 8259232: Bad JNI lookup during printing
  • 7daf680: 8241948: enhance list of environment variables printed in hs_err file
  • efc81a3: 8264640: CMS ParScanClosure misses a barrier
  • f1e4e0b: 8257988: Remove JNF dependency from libsaproc/MacosxDebuggerLocal.m
  • 2e9b3a0: 8260616: Removing remaining JNF dependencies in the java.desktop module
  • df2818b: 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
  • 47ec3b8: 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
  • cdb993e: 8259343: [macOS] Update JNI error handling in Cocoa code.
  • ad45c98: 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@yan-too
Copy link
Collaborator Author

@yan-too yan-too commented Apr 15, 2021

/integrate

@openjdk openjdk bot closed this Apr 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 15, 2021

@yan-too Since your change was applied there have been 9 commits pushed to the master branch:

  • c32180e: 8259232: Bad JNI lookup during printing
  • 7daf680: 8241948: enhance list of environment variables printed in hs_err file
  • efc81a3: 8264640: CMS ParScanClosure misses a barrier
  • f1e4e0b: 8257988: Remove JNF dependency from libsaproc/MacosxDebuggerLocal.m
  • 2e9b3a0: 8260616: Removing remaining JNF dependencies in the java.desktop module
  • df2818b: 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
  • 47ec3b8: 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
  • cdb993e: 8259343: [macOS] Update JNI error handling in Cocoa code.
  • ad45c98: 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code

Your commit was automatically rebased without conflicts.

Pushed as commit 2b18941.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 15, 2021

Webrevs

@yan-too yan-too deleted the yan-too:stl8244853 branch Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant