Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259585: [macos] Bad JNI lookup error : Accessible actions do not work on macOS #184

Closed
wants to merge 1 commit into from

Conversation

@omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented Apr 15, 2021

I'd like to backport JDK-8259585 to jdk13u for parity with jdk11u.
The original patch applied cleanly.
Tested with SwingSet2 demo as described in the comment to the issue.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259585: [macos] Bad JNI lookup error : Accessible actions do not work on macOS

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/184/head:pull/184
$ git checkout pull/184

Update a local copy of the PR:
$ git checkout pull/184
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/184/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 184

View PR using the GUI difftool:
$ git pr show -t 184

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/184.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 15, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b6d51e15549e11be583625d908192d9f7f049489 8259585: [macos] Bad JNI lookup error : Accessible actions do not work on macOS Apr 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 15, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 15, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8259585: [macos] Bad JNI lookup error : Accessible actions do not work on macOS

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 2b18941: 8244853: The static build of libextnet is missing the JNI_OnLoad_extnet function
  • c32180e: 8259232: Bad JNI lookup during printing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 15, 2021

Webrevs

@omikhaltsova
Copy link
Contributor Author

@omikhaltsova omikhaltsova commented Apr 15, 2021

/integrate

@openjdk openjdk bot added the sponsor label Apr 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 15, 2021

@omikhaltsova
Your change (at version 04ce30c) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Apr 16, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@yan-too @omikhaltsova Since your change was applied there have been 2 commits pushed to the master branch:

  • 2b18941: 8244853: The static build of libextnet is missing the JNI_OnLoad_extnet function
  • c32180e: 8259232: Bad JNI lookup during printing

Your commit was automatically rebased without conflicts.

Pushed as commit 8de0239.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@omikhaltsova omikhaltsova deleted the backport-b6d51e15 branch May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants