Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256359: AArch64: runtime/ReservedStack/ReservedStackTestCompiler.java fails #186

Closed
wants to merge 1 commit into from
Closed

8256359: AArch64: runtime/ReservedStack/ReservedStackTestCompiler.java fails #186

wants to merge 1 commit into from

Conversation

@snazarkin
Copy link

@snazarkin snazarkin commented Apr 19, 2021

Please review backport of JDK-8256359. Patch applies cleanly except update of ProblemList.txt is not required since JDK-8256803 was not backported to jdk13. I was not able to reproduce the crash on any board accessible for tests, but the patch fixes obvious error and required for parity with jdk11


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8256359: AArch64: runtime/ReservedStack/ReservedStackTestCompiler.java fails

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/186/head:pull/186
$ git checkout pull/186

Update a local copy of the PR:
$ git checkout pull/186
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/186/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 186

View PR using the GUI difftool:
$ git pr show -t 186

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/186.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 19, 2021

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4e43b28858b0c7c9fb7ad91a506b61aa1d554f86 8256359: AArch64: runtime/ReservedStack/ReservedStackTestCompiler.java fails Apr 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

This backport pull request has now been updated with issue from the original commit.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 19, 2021

Webrevs

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Apr 20, 2021

NB: in bug description it is stated "tier2 test failure". Could you run that set of tests as well? And, is a comment at line 656 still valid?

@snazarkin
Copy link
Author

@snazarkin snazarkin commented Apr 20, 2021

@yan-too the test is a part of tier2 group, but I tried it individually. Will run whole hotspot set.

Regarding the comment. The code and comments equals to the related pieces at jdk/jdk11. Anyway the comment is right: we're still loading sender sp

@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2021

@snazarkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8256359: AArch64: runtime/ReservedStack/ReservedStackTestCompiler.java fails

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 6313a7c: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X
  • 1d1837b: Merge
  • f007648: 8257001: Improve HTTP client support
  • 02ef513: 8249906: Enhance opening JARs
  • 7017551: 8261183: Follow on to Make lists of normal filenames
  • 0c5501b: 8253799: Make lists of normal filenames
  • 7002ef5: 8250568: Less ambiguous processing
  • ca2baf7: 8259633: compiler/graalunit/CoreTest.java fails with NPE after JDK-8244543
  • 079cda1: 8244543: Enhanced handling of abstract classes
  • 0acf828: 8244473: Contextualize registration for JNDI

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 21, 2021
@snazarkin
Copy link
Author

@snazarkin snazarkin commented Apr 21, 2021

/integrate

@openjdk openjdk bot added the sponsor label Apr 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2021

@snazarkin
Your change (at version 528df00) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Apr 21, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2021

@yan-too @snazarkin Since your change was applied there have been 10 commits pushed to the master branch:

  • 6313a7c: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X
  • 1d1837b: Merge
  • f007648: 8257001: Improve HTTP client support
  • 02ef513: 8249906: Enhance opening JARs
  • 7017551: 8261183: Follow on to Make lists of normal filenames
  • 0c5501b: 8253799: Make lists of normal filenames
  • 7002ef5: 8250568: Less ambiguous processing
  • ca2baf7: 8259633: compiler/graalunit/CoreTest.java fails with NPE after JDK-8244543
  • 079cda1: 8244543: Enhanced handling of abstract classes
  • 0acf828: 8244473: Contextualize registration for JNDI

Your commit was automatically rebased without conflicts.

Pushed as commit ee8051f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@snazarkin snazarkin deleted the snazarkin:backport-8256359 branch Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants