-
Notifications
You must be signed in to change notification settings - Fork 28
8256359: AArch64: runtime/ReservedStack/ReservedStackTestCompiler.java fails #186
Conversation
👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
NB: in bug description it is stated "tier2 test failure". Could you run that set of tests as well? And, is a comment at line 656 still valid? |
@yan-too the test is a part of tier2 group, but I tried it individually. Will run whole hotspot set. Regarding the comment. The code and comments equals to the related pieces at jdk/jdk11. Anyway the comment is right: we're still loading sender sp |
@snazarkin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@snazarkin |
/sponsor |
@yan-too @snazarkin Since your change was applied there have been 10 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit ee8051f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review backport of JDK-8256359. Patch applies cleanly except update of ProblemList.txt is not required since JDK-8256803 was not backported to jdk13. I was not able to reproduce the crash on any board accessible for tests, but the patch fixes obvious error and required for parity with jdk11
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/186/head:pull/186
$ git checkout pull/186
Update a local copy of the PR:
$ git checkout pull/186
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/186/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 186
View PR using the GUI difftool:
$ git pr show -t 186
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/186.diff