Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8247753: UIManager.getSytemLookAndFeelClassName() returns wrong value on Fedora 32 #188

Closed
wants to merge 1 commit into from

Conversation

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Apr 21, 2021

This patch does change some code inside a condition clause in a test. Now, in jdk17 that condition (so, context for this fix) checks for linux only but in jdk13 it checks also for solaris. Other than that, patch goes clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8247753: UIManager.getSytemLookAndFeelClassName() returns wrong value on Fedora 32

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/188/head:pull/188
$ git checkout pull/188

Update a local copy of the PR:
$ git checkout pull/188
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/188/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 188

View PR using the GUI difftool:
$ git pr show -t 188

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/188.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 21, 2021

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 79a4a019bba1c99bef2377fe88f1464943530a55 8247753: UIManager.getSytemLookAndFeelClassName() returns wrong value on Fedora 32 Apr 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2021

This backport pull request has now been updated with issue from the original commit.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 21, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8247753: UIManager.getSytemLookAndFeelClassName() returns wrong value on Fedora 32

Reviewed-by: dcherepanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • bc1d8d5: 8251549: Update docs on building for Git

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 22, 2021
@yan-too
Copy link
Collaborator Author

@yan-too yan-too commented Apr 22, 2021

/integrate

@openjdk openjdk bot closed this Apr 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@yan-too Since your change was applied there have been 2 commits pushed to the master branch:

  • 3075cb0: 8262110: DST starts from incorrect time in 2038
  • bc1d8d5: 8251549: Update docs on building for Git

Your commit was automatically rebased without conflicts.

Pushed as commit 6389acf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the gnome8247753 branch Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants