Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8264821: DirectIOTest fails on a system with large block size #193

Closed
wants to merge 1 commit into from
Closed

8264821: DirectIOTest fails on a system with large block size #193

wants to merge 1 commit into from

Conversation

snazarkin
Copy link
Contributor

@snazarkin snazarkin commented Apr 28, 2021

Please review the backport of the fix for 8264821. The test failed on FS with rw block larger than 4k. The fix doesn't apply cleanly due to missed "8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports".
Changes were made manually

  • copyright year
  • isDirectIOSupportedByFS remains in the code

Related JDK-8265231 is not necessary since public method is not removed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264821: DirectIOTest fails on a system with large block size

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/193/head:pull/193
$ git checkout pull/193

Update a local copy of the PR:
$ git checkout pull/193
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/193/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 193

View PR using the GUI difftool:
$ git pr show -t 193

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/193.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 28, 2021

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7e4cd480206891550828d1fdfebae57ecc19ed37 8264821: DirectIOTest fails on a system with large block size Apr 28, 2021
@openjdk
Copy link

openjdk bot commented Apr 28, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 28, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 28, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented May 4, 2021

@snazarkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8264821: DirectIOTest fails on a system with large block size

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 6623cfe: 8230010: Remove jdk8037819/BasicTest1.java
  • a46fd36: 8255845: Memory leak in imageFile.cpp
  • da3c598: Merge
  • 6d17fca: Merge
  • 39972a9: 8265837: Update version .jcheck/conf in jdk13u to be 13.0.8

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 4, 2021
@snazarkin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 4, 2021
@openjdk
Copy link

openjdk bot commented May 4, 2021

@snazarkin
Your change (at version e971868) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented May 4, 2021

/sponsor

@openjdk openjdk bot closed this May 4, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 4, 2021
@openjdk
Copy link

openjdk bot commented May 4, 2021

@yan-too @snazarkin Since your change was applied there have been 5 commits pushed to the master branch:

  • 6623cfe: 8230010: Remove jdk8037819/BasicTest1.java
  • a46fd36: 8255845: Memory leak in imageFile.cpp
  • da3c598: Merge
  • 6d17fca: Merge
  • 39972a9: 8265837: Update version .jcheck/conf in jdk13u to be 13.0.8

Your commit was automatically rebased without conflicts.

Pushed as commit 1c24c09.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@snazarkin snazarkin deleted the backport-8264821 branch May 6, 2021 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants