-
Notifications
You must be signed in to change notification settings - Fork 28
8264821: DirectIOTest fails on a system with large block size #193
Conversation
👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@snazarkin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@snazarkin |
/sponsor |
@yan-too @snazarkin Since your change was applied there have been 5 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 1c24c09. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review the backport of the fix for 8264821. The test failed on FS with rw block larger than 4k. The fix doesn't apply cleanly due to missed "8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports".
Changes were made manually
Related JDK-8265231 is not necessary since public method is not removed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/193/head:pull/193
$ git checkout pull/193
Update a local copy of the PR:
$ git checkout pull/193
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/193/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 193
View PR using the GUI difftool:
$ git pr show -t 193
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/193.diff